Things I Hate…

As a CTO and an architect, I reviewed more codes than anyone can take in a lifetime. It’s a real kick in the ass now that I actually have to work on the code I find irritating. Here’s a short list of Rails code that I just can’t stand.

1. One controller apps - the entire app is in one controller with thousands of lines of code.
2. Embedding functions in views rather than putting them in helpers. It’s a modern day spaghetti code.
3. Overly partialed views - putting everything in partials when it really doesn’t need to be that way.
4. Fat controllers - everything’s in controllers, including the business logics.
5. Uncommented code - no, not everything’s obvious

It’s clear that even with a very opinionated framework, you can still write extremely ugly code.

June 17, 2008 | Filed Under Rant

Comments

Leave a Reply

You must be logged in to post a comment.